-
Notifications
You must be signed in to change notification settings - Fork 4
ld/add Jensen and TurbOPark wake models #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lynna-deng
wants to merge
11
commits into
main
Choose a base branch
from
add-jensen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
47f2b3b
Added Jensen and TurbOPark wake models to imports upon initialization
lynna-deng 2c16573
Added Niayifar quadratic wake superposition option
lynna-deng e97e2e5
Added Jensen, top hat TurbOPark, Gaussian TurbOPark wake models
lynna-deng dd617df
Added memory-friendly superimposed wind speed computation
lynna-deng f6d3a6a
Merge remote-tracking branch 'origin/main' into add-jensen
lynna-deng b5bc028
Renamed A parameter and added comments
42e9585
Added tilt compatibility and renamed A parameter
966dd1b
Merge remote-tracking branch 'origin/main' into add-jensen
7fc5055
Added comments and renamed A parameter
768f6c3
Added Jensen and TurbOPark wake model descriptions
14decf1
Fixed top hat TurbOPark import in initialization
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,3 +25,7 @@ def __call__(self, base_windfield: Windfield, wakes: list[Wake]) -> Windfield: | |
| class Dominant(Superposition): | ||
| def __call__(self, base_windfield: Windfield, wakes: list[Wake]) -> Windfield: | ||
| return Superimposed(base_windfield, wakes, method="dominant") | ||
|
|
||
| class NQuadratic(Superposition): | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we could use "NiayifarQuadratic" just to make the name more clear? Up to you, just an idea! |
||
| def __call__(self, base_windfield: Windfield, wakes: list[Wake]) -> Windfield: | ||
| return Superimposed(base_windfield, wakes, method="nquadratic") | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add "JensenWakeModel, TurbOParkWakeModel" to the "from mitwindfarm import..." line