fix(Makefile): build user_saml with npm (NSW-1074) - #177
Open
printminion-co wants to merge 1 commit into
Open
printminion-co wants to merge 1 commit into
printminion-co wants to merge 1 commit into
Conversation
user_saml v8.4.0 switched to a vite build and no longer commits its js/ bundle, so composer-only packaging would ship it without its admin UI. Move it from COMPOSER_ONLY_APPS to FULL_BUILD_APPS. Refs: NSW-1069 Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
4 tasks
printminion-co
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
user_samlfromCOMPOSER_ONLY_APPStoFULL_BUILD_APPSin theMakefile.user_saml v8.4.0 (the NC33 upgrade in IONOS-Productivity/ncw-server#383) switched to a vite build and no longer commits its
js/bundle (v7.1.3: nopackage.json, 4 tracked files injs/; v8.4.0:package.jsonwith"build": "vite …", 0 tracked injs/). With composer-only packaging, the artifact would ship user_saml without its admin UI.Verified
make validate_app_list_uniqueness: all apps uniquely categorized, no conflictsmake generate_external_apps_matrix_json: user_saml now hashas_npm: true, targetbuild_user_saml_appnpm ciand vite, and emitsjs/user_saml-admin.mjs,js/user_saml-selectUserBackEnd.mjsandjs/user_saml-timezone.mjsMerge order
Merge this first, then re-point the
IONOSgitlink in IONOS-Productivity/ncw-server#383 to the merged commit.Important:
build_full_apprunsnpm ciunconditionally, and user_saml v7.1.3, whichionos-dev-v33still pins, has nopackage.json. So once this is onmain, don't move the ncw-serverIONOSgitlink tomainonionos-dev-v33before IONOS-Productivity/ncw-server#383 lands. That PR moves both together, so the user_saml build would fail anywhere they get out of step. Re-point #383 to the merged commit and merge it right after this one.Jira: NSW-1074 (sub-task of NSW-1069)