IONOS(user_saml): update submodule to v8.4.0 (NC33, major) (NSW-1074) - #383
Draft
printminion-co wants to merge 2 commits into
Draft
printminion-co wants to merge 2 commits into
printminion-co wants to merge 2 commits into
Conversation
…th npm) user_saml v8.4.0 no longer commits its js/ bundle; build it as a full (composer + npm) app. Pre-merge pin of the ncw-config branch mk/dev/NSW-1069-user_saml-full-build. SHA: 7dfac2736db756e5fd06a724cc951481091be0c0 Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
…a mirror) Both IONOS commits (IDelegatedSettings + its test) are upstreamed in v8.4.0, so the fork carries no delta. Tag: https://github.com/IONOS-Productivity/nc-user_saml/releases/tag/v8.4.0 SHA: 218c25fe48d322d28826db1628f9917baed62df7 Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
3 tasks
printminion-co
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Major fork bump split out of #381 so it can be tested and reverted on its own:
apps-external/user_samlfrom IONOS forkv7.1.3-6e99e21to upstream v8.4.0 (NC 32–36), plus theIONOS(ncw-config) build change v8 needs.IONOS→ 7dfac27 (ncw-config branchmk/dev/NSW-1069-user_saml-full-build): move user_saml fromCOMPOSER_ONLY_APPStoFULL_BUILD_APPS. v8.4.0 switched to a vite build and no longer commitsjs/; composer-only packaging would ship it without its admin UI. Also carries 892760b (already onionos-dev-v33).apps-external/user_saml→ v8.4.0, now a vanilla mirror: both IONOS commits (IDelegatedSettings+ its test) are upstreamed in v8.4.0 and were dropped. Thenc-user_samlfork hasionos-dev-v33and tag v8.4.0 pushed.Notes
getAuthorizedAppConfig()lets delegated admins write 4 user_saml app-config keys:type,general-require_provisioned_account,general-allow_multiple_user_back_ends,directLoginName. The dropped IONOS patch allowed none.js/user_saml-admin.mjsetc. for user_saml.IONOShere to the merged commit and merge this right after. ncw-configmainmust not be pinned onionos-dev-v33while user_saml is still v7.1.3, because the full build runsnpm ciand v7.1.3 has nopackage.json.Needs testing (v7 → v8)
.dev/container/check_release.sh pr-383 ncw— validate pr locallyRelated: #381 (rest of the fork sweep). Jira: NSW-1074 (sub-task of NSW-1069)