Skip to content

fix: require API key auth for /custom-mcp endpoint to prevent unauthenticated RCE #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Joshua-Medvinsky wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: require API key auth for /custom-mcp endpoint to prevent unauthenticated RCE #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/ii_server/mcp/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,13 @@ async def add_mcp_config(request):
config = await request.json()
if not config:
return JSONResponse({"error": "Invalid request"}, status_code=400)

# Require API key authentication for MCP config registration
api_key = request.headers.get("X-API-Key") or request.query_params.get("api_key")
expected_key = os.getenv("MCP_API_KEY")
if not expected_key or api_key != expected_key:
return JSONResponse({"error": "Unauthorized"}, status_code=401)

mcp_servers = config.get("mcpServers", {})
for server_name, server_conf in mcp_servers.items():
single_config = {"mcpServers": {server_name: server_conf}}
Expand Down