Skip to content

Add Ord instances for predicate failures#5850

Draft
neilmayhew wants to merge 6 commits into
masterfrom
nm/predicate-failure-ord
Draft

Add Ord instances for predicate failures#5850
neilmayhew wants to merge 6 commits into
masterfrom
nm/predicate-failure-ord

Conversation

@neilmayhew
Copy link
Copy Markdown
Contributor

@neilmayhew neilmayhew commented May 20, 2026

Description

We want to be able to have Sets of predicate failures which requires them to have Ord instances.

This also requires changes to cardano-base, because some types from base are embedded in some of our predicate failures, which requires those types to have Ord instances and currently they do not.

We add the Ord constraint to the STS class to ensure that no predicate is missed.

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@neilmayhew neilmayhew force-pushed the nm/predicate-failure-ord branch from d1e99a6 to 248a305 Compare May 20, 2026 04:18
@neilmayhew neilmayhew force-pushed the nm/predicate-failure-ord branch 3 times, most recently from d8323c9 to 8f5de6c Compare May 20, 2026 16:37
@neilmayhew neilmayhew force-pushed the nm/predicate-failure-ord branch from 8f5de6c to 3f10827 Compare May 21, 2026 18:39
@neilmayhew neilmayhew force-pushed the nm/predicate-failure-ord branch from 3f10827 to ea23c32 Compare May 25, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant