Skip to content

Report missing build parameter references clearly - #370

Merged
DecSmith42 merged 2 commits into
mainfrom
copilot/fix-buildresolver-addparam-error
Jul 31, 2026
Merged

Report missing build parameter references clearly#370
DecSmith42 merged 2 commits into
mainfrom
copilot/fix-buildresolver-addparam-error

Conversation

Copilot AI commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

BuildResolver threw KeyNotFoundException when a target referenced a parameter not registered by the build, obscuring the configuration error.

  • Resolution

    • Validate parameter lookups, including chained parameters.
    • Throw BuildConfigurationException identifying the target and missing parameter.

  • Coverage

    • Add regression coverage for targets referencing undefined parameters.

Copilot AI review requested due to automatic review settings July 31, 2026 00:42
Copilot AI reviewed Jul 31, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot AI linked an issue Jul 31, 2026 that may be closed by this pull request
BuildResolver.AddParamAndChildren can attempt to add params that haven't been added to the build #369
Closed
Copilot AI review requested due to automatic review settings July 31, 2026 00:44
Copilot AI reviewed Jul 31, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because there is no eligible user to bill. To allow Copilot reviews on bot-authored pull requests, enable direct organization billing in your organization's Copilot settings.

Copilot AI changed the title [WIP] Fix BuildResolver.AddParamAndChildren to handle missing params gracefully Report missing build parameter references clearly Jul 31, 2026
Copilot AI requested a review from DecSmith42 July 31, 2026 00:49
@DecSmith42
DecSmith42 marked this pull request as ready for review July 31, 2026 00:50
@DecSmith42
DecSmith42 enabled auto-merge July 31, 2026 00:51
@DecSmith42
DecSmith42 requested a review from Copilot July 31, 2026 00:51
Copilot AI reviewed Jul 31, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@DecSmith42
DecSmith42 merged commit d66d4ee into main Jul 31, 2026
51 of 80 checks passed
@DecSmith42
DecSmith42 deleted the copilot/fix-buildresolver-addparam-error branch July 31, 2026 01:03
This was referenced Aug 7, 2026
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
+1 more reviewer
@DecSmith42 DecSmith42 DecSmith42 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@DecSmith42 DecSmith42

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BuildResolver.AddParamAndChildren can attempt to add params that haven't been added to the build

3 participants

@DecSmith42