fix(ci): require readyz JSON body in healthcheck, not just HTTP 200#40
Merged
Conversation
A live workflow_dispatch against prod returned HTTP 200 even though
/healthz is not yet deployed: the shell's React Router SSR catch-all
answers 200 (HTML) for the unmatched path, so a status-code-only check is
a false-healthy. Require the readiness-backed body ({"status":"ok"}) in
addition to 200 so a green run proves we actually reached /healthz and the
backend is up. A stale/rolled-back deploy that loses the route now
correctly goes red instead of silently passing.
ItsThompson
enabled auto-merge
July 18, 2026 17:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up hardening to the website healthcheck workflow added in #39.
A live
workflow_dispatchofhealthcheck.ymlagainst prod returned HTTP 200 and passed, even though/healthzwas not yet deployed. Root cause: the shell's React Router SSR catch-all answers 200 with the SPA HTML shell for any unmatched path, so the original status-code-only probe was a false-healthy — a green run proved nothing about the backend.Change
The probe now requires the readiness-backed JSON body (
"status":"ok") in addition to HTTP 200. A 200-HTML fallback no longer counts as healthy.200+{"status":"ok"}200+ HTML (prod today, pre-deploy)503+{"status":"unhealthy",...}This also hardens against a future stale/rolled-back deploy that loses the
/healthzroute silently showing green.Testing
actionlint(incl. shellcheck): clean.Notes
.github/workflows/healthcheck.yml.HEALTHCHECK_TOKEN+DISCORD_WEBHOOK_URLsecrets are now set and feat: website health check cron (standalone GH Actions workflow) #39 was merged, so the dispatch could reach prod.