Skip to content

fix(ci): require readyz JSON body in healthcheck, not just HTTP 200 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ItsThompson merged 1 commit into from
Jul 18, 2026
+6 −1
Merged

fix(ci): require readyz JSON body in healthcheck, not just HTTP 200 #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/healthcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,12 @@ jobs:
-w "%{http_code}" \
"$url") || true
echo "Attempt ${i}/${attempts}: HTTP ${http_code}"
if [ "$http_code" = "200" ]; then
# A 200 status alone is not sufficient: the shell's React Router SSR
# catch-all also answers 200 (HTML) for an unmatched path, so a stale
# deploy without /healthz would look "healthy". Require the
# readiness-backed JSON body ({"status":"ok"}) so a green run proves
# we actually reached /healthz and the backend is up.
if [ "$http_code" = "200" ] && grep -q '"status":"ok"' /tmp/healthz_body; then
echo "healthz OK"
exit 0
fi
Expand Down
Loading