Skip to content

bug: escape backticks in svg text#5395

Closed
saurabhhhcodes wants to merge 1 commit into
JhaSourav07:mainfrom
saurabhhhcodes:codex/svg-backtick-escape
Closed

bug: escape backticks in svg text#5395
saurabhhhcodes wants to merge 1 commit into
JhaSourav07:mainfrom
saurabhhhcodes:codex/svg-backtick-escape

Conversation

@saurabhhhcodes

Copy link
Copy Markdown
Contributor

Escapes backticks in SVG/XML text output so user-controlled strings cannot break out of attributes.\n\nValidation:\n- npm test -- --run lib/svg/generator.escapeXML.test.ts lib/svg/generator.test.ts\n\nCloses #5264

@vercel

vercel Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Someone is attempting to deploy a commit to the jhasourav07's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hey @saurabhhhcodes! Thanks for your interest in contributing to CommitPulse! 🙏

Unfortunately, this PR has been automatically closed because you are not assigned to the linked issue #5264 — bug: Escape all special XML characters to prevent SVG attribute injection.

To avoid this in the future, please follow these steps:

  1. Claim the issue — Comment /claim on #5264 if you are the issue author, or ask a maintainer to /assign you.
  2. Wait for confirmation — The bot will confirm your assignment with a ✅ reply.
  3. Then open your PR — Link the issue with Fixes #5264 in your description.

💡 You can be assigned to up to 5 open issues at a time. Check your current assignments before claiming a new one.

We look forward to your contribution once you're assigned! 🚀

@github-actions github-actions Bot closed this Jun 12, 2026
@Aamod-Dev Aamod-Dev added mentor:Aamod007 level:intermediate Moderate complexity tasks quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:bug Something isn't working as expected labels Jun 14, 2026

@Aamod-Dev Aamod-Dev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid escaping! I went through the changes and ensuring backticks are safely escaped inside SVG text nodes prevents malformed XML strings from breaking the image parser.
Labels applied:

  • level:intermediate: String escaping logic.
  • quality:clean: Protects the XML generator.
  • ype:bug: Fixes rendering crashes.

@Aamod-Dev Aamod-Dev added GSSoC 2026 gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 14, 2026
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:intermediate Moderate complexity tasks mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. type:bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants