Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/svg/generator.escapeXML.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ describe('escapeXML', () => {
expect(escapeXML('hello world')).toBe('hello world');
});

it('should escape backticks to prevent attribute breakout', () => {
expect(escapeXML('label=`alert(1)`')).toBe('label=`alert(1)`');
});

it('should return an empty string unchanged', () => {
expect(escapeXML('')).toBe('');
});
Expand Down
5 changes: 4 additions & 1 deletion lib/svg/generator.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1529,9 +1529,12 @@ describe('escapeXML', () => {
});

it('leaves a safe string unchanged', () => {
const safe = 'Hello World 123!@#%^*()_+-=[]{}|;:,./?`~';
const safe = 'Hello World 123!@#%^*()_+-=[]{}|;:,./?~';
expect(escapeXML(safe)).toBe(safe);
});
it('escapes backticks in XML-sensitive strings', () => {
expect(escapeXML('onload=`alert(1)`')).toBe('onload=`alert(1)`');
});
it('escapes script injection characters <script>&" together', () => {
expect(escapeXML('<script>&"')).toBe('&lt;script&gt;&amp;&quot;');
});
Expand Down
3 changes: 2 additions & 1 deletion lib/svg/generator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,8 @@ export function escapeXML(str: string): string {
.replace(/</g, '&lt;')
.replace(/>/g, '&gt;')
.replace(/"/g, '&quot;')
.replace(/'/g, '&#39;');
.replace(/'/g, '&#39;')
.replace(/`/g, '&#96;');
}

export function particleCount(count?: number | null): number {
Expand Down
Loading