Reduce the maximum number of iterations for iterative refinement. - #144
Open
MaxenceGollier wants to merge 2 commits into
Open
Reduce the maximum number of iterations for iterative refinement.#144MaxenceGollier wants to merge 2 commits into
MaxenceGollier wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces the default maximum number of iterations used by the Golub–Riley iterative refinement routine, aligning the library’s default behavior with the referenced discussion.
Changes:
- Lowered the default
max_iterforqrm_golub_rileyandqrm_golub_riley!from 50 to 3. - Updated the
qrm_golub_riley!docstring example to reflect the new default.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/utils.jl |
Changes the default max_iter keyword argument in the Golub–Riley implementation/wrapper. |
src/QRMumps.jl |
Updates documentation text referencing the default max_iter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 75.71% 84.05% +8.34%
==========================================
Files 5 6 +1
Lines 803 1079 +276
==========================================
+ Hits 608 907 +299
+ Misses 195 172 -23 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this comment.