Skip to content

Reduce the maximum number of iterations for iterative refinement. #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxenceGollier wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reduce the maximum number of iterations for iterative refinement. #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90a2a96
update iterative refinement max_iter
MaxenceGollier Apr 8, 2026
1b2bcf9
Update src/QRMumps.jl
MaxenceGollier Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/QRMumps.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ function qrm_update_shift_spmat! end
function qrm_golub_riley end

@doc raw"""
qrm_golub_riley!(shifted_spmat, spfct, x, b, Δx, y; α = ϵm, max_iter = 50, tol = ϵm, transp = 'n')
qrm_golub_riley!(shifted_spmat, spfct, x, b, Δx, y, Δy; α = ϵm, max_iter = 3, tol = ϵm, transp = 'n')

This method implements the Golub-Riley iteration.
Given a (possibly ill-conditionned or rank deficient) system `Ax = b` where `A` can have any shape `m×n`, compute `x = A†b = Aᵀ(AAᵀ)†b` where `A†` is the Moore-Penrose pseudoinverse of `A`.
Expand Down
4 changes: 2 additions & 2 deletions src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ function qrm_update_shift_spmat!(shifted_spmat :: qrm_shifted_spmat{T}, α :: T)
shifted_spmat.spmat.val[shifted_spmat.spmat.mat.nz - shifted_spmat.spmat.mat.m + 1:end] .= sqrt(α)
end

function qrm_golub_riley(spmat :: qrm_spmat{T}, b :: AbstractVector{T}; α :: T = T(eps(real(T))), max_iter :: Int = 50, tol :: Real = eps(real(T)), transp :: Char = 'n') where T
function qrm_golub_riley(spmat :: qrm_spmat{T}, b :: AbstractVector{T}; α :: T = T(eps(real(T))), max_iter :: Int = 3, tol :: Real = eps(real(T)), transp :: Char = 'n') where T
shifted_spmat = qrm_shift_spmat(spmat, α)
spfct = qrm_spfct_init(shifted_spmat.spmat)
n = shifted_spmat.spmat.mat.n
Expand Down Expand Up @@ -250,7 +250,7 @@ function qrm_golub_riley!(
y :: AbstractVector{T},
Δy :: AbstractVector{T};
α :: T = T(eps(real(T))),
max_iter :: Int = 50,
max_iter :: Int = 3,
tol :: Real = eps(real(T)),
transp :: Char = 'n'
) where T
Expand Down
Loading