fix(core): cap ChordMatcher buffer to prevent unbounded growth#1714
fix(core): cap ChordMatcher buffer to prevent unbounded growth#1714ionfwsrijan wants to merge 1 commit into
Conversation
The buffer grew on each partial chord match with no upper limit. If a user typed keys matching a chord prefix indefinitely, the buffer would grow unbounded. Added maxBufferSize (default 10) that resets the buffer when exceeded.
|
Warning Review limit reached
More reviews will be available in 29 minutes and 33 seconds. Learn how PR review limits work. To continue reviewing without waiting, enable usage-based billing in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@Karanjot786 Please review this |
Description
ChordMatcherstores every key press in its internal buffer without a size limit. Holding down a key floods the buffer, and the chord is never matched against the expected sequence, breaking chord detection.Changes
maxBufferSizeoption (default 10) to theChordMatcherconstructorTesting
Closes #1711