Skip to content

fix(core): cap ChordMatcher buffer to prevent unbounded growth #1714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ionfwsrijan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): cap ChordMatcher buffer to prevent unbounded growth #1714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/core/src/input/ChordMatcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ export interface Chord {

export interface ChordMatcherOptions {
timeoutMs?: number;
maxBufferSize?: number;
}

function getKeyEventToken(event: KeyEvent): string {
Expand All @@ -27,10 +28,12 @@ export class ChordMatcher {
private _nextId = 0;
private _buffer: string[] = [];
private _timeoutMs: number;
private _maxBufferSize: number;
private _timer: ReturnType<typeof setTimeout> | null = null;

constructor(opts?: ChordMatcherOptions) {
this._timeoutMs = opts?.timeoutMs ?? 800;
this._maxBufferSize = opts?.maxBufferSize ?? 10;
}

bind(keys: string[], handler: () => void): () => void {
Expand All @@ -49,6 +52,12 @@ export class ChordMatcher {

const token = getKeyEventToken(event);
let candidate = [...this._buffer, token];

if (candidate.length > this._maxBufferSize) {
this._buffer = [];
candidate = [token];
}

let matchingBindings = this._getMatchingBindings(candidate);

if (matchingBindings.length === 0) {
Expand Down
Loading