ssd1306 base - #50
ssd1306 base#50dmytrokirtoka wants to merge 4 commits into
Conversation
| dev_info(&drv_client->dev, "%s: enter\n", __func__); | ||
| } | ||
|
|
||
| static void i2c_ssd1306_copyarea(struct fb_info *info, |
There was a problem hiding this comment.
Why have you desided to refuse of these methods' functional and just use write method?
There was a problem hiding this comment.
I did the minimum possible driver functionality for my purposes (vizualization app)
DevyatovAndrey
left a comment
DevyatovAndrey
left a comment
There was a problem hiding this comment.
Good point of using update thread!
Nevertheless could you please make changes listed below?
| .fb_blank = i2c_ssd1306_blank, | ||
| .fb_fillrect = i2c_ssd1306_fillrect, | ||
| .fb_copyarea = i2c_ssd1306_copyarea, | ||
| .fb_imageblit = i2c_ssd1306_imageblit, |
There was a problem hiding this comment.
I guess these initialisation could be siplier since you didn't use most of framebuffer methods
There was a problem hiding this comment.
maybe, but I left a message output, what if something is needed?
AleksandrBulyshchenko
left a comment
AleksandrBulyshchenko
left a comment
There was a problem hiding this comment.
Please split the PR into functional commits
|
this driver was written from an empty sheet, |
👍 I see.
I hope at least *.dtsi hasn't been written from an empty sheet. |
Add update screen thread and write op
237b663 to
cf55c51
Compare
|
split to functional parts |
|
@dmytrokirtoka, |
3 participants
added simple lcd driver communicated with i2c interface
driver supports frame buffer read/write only
this operations enough to use for its purpose
Signed-off-by: dmytro.kirtoka dimk334@gmail.com