Skip to content

feat(vtk-wasm)!: update to v2 which require vtk>=9.6#72

Merged
jourdain merged 9 commits into
masterfrom
bump-vtk-wasm
Jun 26, 2026
Merged

feat(vtk-wasm)!: update to v2 which require vtk>=9.6#72
jourdain merged 9 commits into
masterfrom
bump-vtk-wasm

Conversation

@jourdain

Copy link
Copy Markdown
Collaborator

This is a breaking change as some API have changed, but the main usage of the widget should remain mostly unchanged.

@jourdain jourdain requested a review from jspanchu June 23, 2026 21:25
@jourdain jourdain marked this pull request as draft June 23, 2026 21:25
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.58%. Comparing base (c357ac5) to head (7989ec1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #72   +/-   ##
=======================================
  Coverage   70.58%   70.58%           
=======================================
  Files           2        2           
  Lines          17       17           
=======================================
  Hits           12       12           
  Misses          5        5           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jourdain

jourdain commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

Bugs and issues to fix before merging:

@jspanchu let's discuss that when you are back online.
FYI @ansbbrooks => The update(options) trigger an updated event with the options as the $event content which could allow client methods to execute custom code based on it.

@jspanchu

Copy link
Copy Markdown
Member

interactive update don't update the 3D scene (cone resolution)

Kitware/vtk-wasm#51

What should we do if we were to support dynamic RenderWindow ID as property?

should the old render window and it's canvas be hidden? or cleaned up?

Validate onMounted and onBeforeUnMount
Make sure the validation example works fully

Can we write automated tests for these two?

@Kitware Kitware deleted a comment from jspanchu Jun 25, 2026
@jourdain jourdain marked this pull request as ready for review June 25, 2026 20:29
@jourdain

Copy link
Copy Markdown
Collaborator Author

@jspanchu should we merge it?

@jourdain jourdain merged commit ad4d92e into master Jun 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants