Skip to content

update Cargo edition & dependencies versions - #317

Merged
cedricchevalier19 merged 9 commits into
LIHPC-Computational-Geometry:masterfrom
imrn99:update-packages
Jan 6, 2026
Merged

cedricchevalier19 merged 9 commits into
LIHPC-Computational-Geometry:masterfrom
imrn99:update-packages

Conversation

@imrn99

@imrn99 imrn99 commented Dec 5, 2025

Copy link
Copy Markdown
Member

Content of the PR:

  • update to 2024 edition & remove the format file which pinned the edition to 2021
    • format with new edition standards
  • add taplo config file for toml formatting
    • format toml files
  • update dependencies to latest versions (excluding rc releases)
    • nalgebra and rand required code changes for builds to succeed, so I made those and ignored other clippy lints, which I can process in a separate PR
  • pin deps to their exact versions

Concerning the flake:

  • I added it because that's how I like to get my toolchain, but I can remove it if desired
  • If we keep both the flake and the Cargo.lock file, I can add a check target to the flake that runs all usual tests (format, lints)
  • removed

CI:

  • I'd like to handle all clippy lints in a dedicated PR, after update CI #318 and this one are merged
  • coverage fails because the current workflow didn't use a token for auth to codecov, they probably changed their rate / policy for tokenless usage. update CI #318 fixes it

For now, it only contains a dev env. If we decide to keep the
`Cargo.lock` file, I will add a check target
also remove the rustfmt file that pinned edition to "2021"
@imrn99

imrn99 commented Dec 5, 2025

Copy link
Copy Markdown
Member Author

I just noticed the root manifest defines workspace members AND is used for the coupe library. Dependencies defined there aren't reused by members, which created some version mismatches.

I'll match the version manually for now and clean the workspace structure separately if that's ok @cedricchevalier19

it is needed by num-parts, which is used by one of the tools
this is temporary, the deps should be properly reused from the workspace
@cedricchevalier19

Copy link
Copy Markdown
Member

I am in favour to allow regular lock and not to require using nix flakes.

I'll look at the PR soon.

@imrn99 imrn99 mentioned this pull request Dec 10, 2025
@cedricchevalier19
cedricchevalier19 merged commit f967823 into LIHPC-Computational-Geometry:master Jan 6, 2026
2 of 4 checks passed
This was referenced Jan 6, 2026
@imrn99
imrn99 deleted the update-packages branch January 8, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants