update Cargo edition & dependencies versions - #317
Merged
cedricchevalier19 merged 9 commits intoJan 6, 2026
Merged
cedricchevalier19 merged 9 commits into
cedricchevalier19 merged 9 commits into
Conversation
For now, it only contains a dev env. If we decide to keep the `Cargo.lock` file, I will add a check target
also remove the rustfmt file that pinned edition to "2021"
Member
Author
|
I just noticed the root manifest defines workspace members AND is used for the coupe library. Dependencies defined there aren't reused by members, which created some version mismatches. I'll match the version manually for now and clean the workspace structure separately if that's ok @cedricchevalier19 |
it is needed by num-parts, which is used by one of the tools
this is temporary, the deps should be properly reused from the workspace
Member
|
I am in favour to allow regular lock and not to require using nix flakes. I'll look at the PR soon. |
Merged
cedricchevalier19
approved these changes
Jan 6, 2026
cedricchevalier19
merged commit Jan 6, 2026
f967823
into
LIHPC-Computational-Geometry:master
2 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content of the PR:
taploconfig file for toml formattingrcreleases)nalgebraandrandrequired code changes for builds to succeed, so I made those and ignored other clippy lints, which I can process in a separate PRConcerning the flake:
I added it because that's how I like to get my toolchain, but I can remove it if desiredIf we keep both the flake and theCargo.lockfile, I can add a check target to the flake that runs all usual tests (format, lints)CI: