update CI - #318
Merged
cedricchevalier19 merged 6 commits intoJan 6, 2026
Merged
update CI#318
Conversation
`--all-targets` results in bench running in CI
Member
|
I have to fix the required checks, but @imrn99 can you look at the failures? |
imrn99
commented
Dec 10, 2025
Member
Author
There was a problem hiding this comment.
- clippy CI fails because we deny warnings; I could comment out the deny option for now and add it back in the PR which will handle all warnings
- format fails due to some Rust code, but I think it would also fail after due to toml files. Both are fixed by #317, where I formatted at the same time I updated the edition
the 3 "pending" jobs are from the old files I believe
| - name: Run clippy | ||
| run: | | ||
| cargo clippy --all-targets -- \ | ||
| -D warnings \ |
Member
Author
There was a problem hiding this comment.
this option makes the CI fail
cedricchevalier19
merged commit Jan 6, 2026
6813840
into
LIHPC-Computational-Geometry:master
3 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update all workflows besides
docker_publishs (not sure what those are supposed to do)