fix: don't panic if PagerDuty routing key is undefined

[sergeytimoshin]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling to prevent potential crashes when sending alerts if a PagerDuty key is missing. Alert notifications are now only attempted when a valid key is present.

[coderabbitai]

Walkthrough

The update refines the error handling in the register_for_epoch_with_retry method of EpochManager. It now conditionally sends a PagerDuty alert only if a routing key is present, avoiding a possible panic from unwrapping a missing key. If the alert fails to send, an error is logged.

Changes

File(s)	Change Summary
forester/src/epoch_manager.rs	Improved error handling in register_for_epoch_with_retry to conditionally send PagerDuty alerts and avoid panics when the routing key is absent.

Estimated code review effort

1 (~2 minutes)

Poem

A rabbit hops through code so neat,
Guarding panics, swift on feet.
PagerDuty now sends with care,
Only if the key is there!
If alerts can't go, logs will show—
Safe and sound, onward we go!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8355614 and 25f2f40.

📒 Files selected for processing (1)

• forester/src/epoch_manager.rs (1 hunks)

🔇 Additional comments (1)

forester/src/epoch_manager.rs (1)

548-564: Excellent defensive programming improvement!

This change correctly addresses the panic issue by safely handling the optional PagerDuty routing key. The implementation properly:

1. Uses if let Some() pattern instead of unwrap() to prevent panics
2. Only attempts to send alerts when a routing key is configured
3. Gracefully logs errors if alert sending fails without crashing the application
4. Maintains the same error return behavior for the registration failure

This is a solid example of making the system more resilient to configuration variations.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.