Skip to content

fix: don't panic if PagerDuty routing key is undefined #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ananas-block merged 1 commit into from
Jul 21, 2025
Merged

fix: don't panic if PagerDuty routing key is undefined #1878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions forester/src/epoch_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -545,23 +545,22 @@ impl<R: Rpc> EpochManager<R> {
if attempt < max_retries - 1 {
sleep(retry_delay).await;
} else {
if let Err(alert_err) = send_pagerduty_alert(
&self
.config
.external_services
.pagerduty_routing_key
.clone()
.unwrap(),
&format!(
"Forester failed to register for epoch {} after {} attempts",
epoch, max_retries
),
"critical",
&format!("Forester {}", self.config.payer_keypair.pubkey()),
)
.await
if let Some(pagerduty_key) =
self.config.external_services.pagerduty_routing_key.clone()
{
error!("Failed to send PagerDuty alert: {:?}", alert_err);
if let Err(alert_err) = send_pagerduty_alert(
&pagerduty_key,
&format!(
"Forester failed to register for epoch {} after {} attempts",
epoch, max_retries
),
"critical",
&format!("Forester {}", self.config.payer_keypair.pubkey()),
)
.await
{
error!("Failed to send PagerDuty alert: {:?}", alert_err);
}
}
return Err(e);
}
Expand Down