R-00374 r8: terminate chat drain and over-budget ticks - #30
Merged
Conversation
Drain Room chat.event with non-blocking recv and a deadline so wait_for_observed can return. Stop apply_pending when pending does not fall or tick.ok is false, and refuse RunTick of more than 64 wire chats. Keep r7 release.flag hold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R-00374 r8 · terminate chat drain and over-budget ticks (RM-00011)
origin/main:e28d2bb1f97673256d9156a57d25a2d0d101bdeb24a2838d1f90dbf75d0aac0bd576223f5fae7701Why
R-00376 live9: after r7 socket hold,
drain_chat_event_deltasblocked onrecv_textuntil 101. Playwright window 33; replay hung ~21 min until killed.apply_pending_chat_tickscould alsocontinueforever if pending ≥ 64 did not fall.What
Non-blocking
try_recv_text+ 50ms drain deadline.apply_pendingstops onpending > 64,!tick.ok, or pending not falling. Host refuses RuntimeRunTickabove 64. Keep r7release.flaghold.Verify
Known gaps