Fix fL/pL unit labels on stommel_boyd2015_volumes.csv + clarify scope#34
Open
madsCodeBuddy wants to merge 3 commits intomainfrom
Open
Fix fL/pL unit labels on stommel_boyd2015_volumes.csv + clarify scope#34madsCodeBuddy wants to merge 3 commits intomainfrom
madsCodeBuddy wants to merge 3 commits intomainfrom
Conversation
The values 1.00E-15 m³ on rows 1, 2, and 3 (Gene & protein expression Space_max, Microbial growth (cellular) Space_max, Community metabolism (patch) Space_min) were labeled '1 fL' but 10⁻¹⁵ m³ = 1 pL = 1000 µm³. 1 fL = 10⁻¹⁸ m³ = 1 µm³, which is the Space_min value, not Space_max. Values unchanged; only the parenthetical unit labels are fixed.
The upper bound of 10⁻¹⁵ m³ (1 pL ≈ 1000 µm³) on Gene & protein expression and Microbial growth (cellular) is too large for bacteria alone (~1-10 µm³). The values stay because the rows are meant to cover microbial diversity broadly — yeast (~30-50 µm³), small algae, etc. Notes column now states this explicitly.
The legend tooltip labels mixed cubic-distance (m³, µm³, etc.) with liter prefix (1 pL), which jars against the m³ y-axis and the rest of the reference markers on the plot. Labels now use bare cubic-distance (1000 µm³). Disambiguating biological context moves to the Notes column where it belongs: - Row 3 now flags that 1000 µm³ ≈ 1000 cells (early biofilm cluster), not a single attached cell, since 'biofilm base' read as the latter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes a unit-prefix typo in
data/datasets/stommel_boyd2015_volumes.csvand clarifies the Notes column on the affected rows.Two commits, surgical edits only — values stay, only labels and notes change.
Commit 1: label fix (
fix:prefix)The value
1.00E-15m³ appears on three rows and was labeled1 fLin all three. But 1 fL = 10⁻¹⁵ L = 10⁻¹⁸ m³ (= 1 µm³, a bacterial cell). The actual 10⁻¹⁵ m³ value is 1 pL = 1000 µm³. Off by a factor of 1000.Fixed labels:
1 fL (single cell)→1 pL (1000 µm³)1 fL (single cell)→1 pL (1000 µm³)1 fL (biofilm base)→1 pL (biofilm base)Commit 2: scope clarification on rows 1 & 2 (
docs:prefix)Upper bound of 1000 µm³ is too large for bacteria alone (~1–10 µm³). The values are kept because the rows span microbial diversity broadly (yeast ~30–50 µm³, small algae up to ~1000 µm³). Notes column now states this so readers don't bounce off the bacterial-only mental model.
What this PR does NOT change
1 pL (biofilm base)label on row 3 — left as-is, but flagging that 1 pL (~1000 cells worth of volume) is a small biofilm patch rather than a single attached cell, so 'biofilm base' may want a follow-up review on its own merits. That's a semantic call, not a unit bug.stommel_boyd2015_volumes_hbw.csvhas the same1 fLmislabel pattern but is a separate dataset (different ProcessType column for Experiments vs. Models split) and not used by the README diagram. Out of scope here.Verification
Diffs touch only the four cells described above — no full-file rewrite, no value changes, no other rows affected.