Skip to content

fix(ci): remove hardcoded branch filters from workflow triggers - #32

Open
erudenko wants to merge 8 commits into
fix/ci-type-errors-and-stale-test-datefrom
fix/ci-workflow-trigger-broadening
Open

fix(ci): remove hardcoded branch filters from workflow triggers#32
erudenko wants to merge 8 commits into
fix/ci-type-errors-and-stale-test-datefrom
fix/ci-workflow-trigger-broadening

Conversation

@erudenko

Copy link
Copy Markdown
Member

What failed

Runs 24063290384, 24029941408, 24029941414, 24029844275, 24276607217 represent a chain of CI failures. Multiple fix PRs have been opened (#22, #23, #28, #31) but the test suite never ran on most of them — only GitGuardian fired. This PR fixes the structural reason why.

Root cause

Both test-plugins.yml and test-stats.yml had a hardcoded branches allowlist:

on:
  push:
    branches: [main, fix/ci-type-errors-and-stale-test-date]
  pull_request:
    branches: [main, fix/ci-type-errors-and-stale-test-date]

Any branch not named exactly main or fix/ci-type-errors-and-stale-test-date is invisible to CI — pushes and PRs from those branches only trigger GitGuardian (which runs on every PR regardless of branch). This explains:

PR Branch CI result
#22 fix/ci-typescript-and-stats-dates GitGuardian only
#23 fix/ci-typescript-and-stats-dates-resolved GitGuardian only
#28 fix/ci-24276607217-browser-use-version GitGuardian only
#31 fix/ci-main-browser-use-version GitGuardian only
#24 fix/ci-24065489776-ts-and-dates ✅ All 7 checks pass

PR #24 works because it targets fix/ci-type-errors-and-stale-test-date directly and the pull_request trigger fires for that base — but every other fix branch created off it is still blind.

Fix

Remove the branches allowlist from both push and pull_request triggers in test-plugins.yml and test-stats.yml. Path filters already limit CI to runs that actually touch relevant files, so there is no noise increase — the only difference is coverage now extends to all branches.

-  push:
-    branches: [main, fix/ci-type-errors-and-stale-test-date]
-    paths: [...]
-  pull_request:
-    branches: [main, fix/ci-type-errors-and-stale-test-date]
-    paths: [...]
+  push:
+    paths: [...]
+  pull_request:
+    paths: [...]

Relationship to other open PRs

The push and pull_request triggers were locked to `main` and
`fix/ci-type-errors-and-stale-test-date`. Any new fix branch was
invisible to CI — exactly the pattern seen in PRs #22, #23, #28, #31
where only GitGuardian ran, not the actual test suite.

Remove the `branches` list entirely so CI fires on any branch/PR that
touches the relevant paths. Path filters still limit noise to changes
that actually affect plugins, claudeup-core, or the marketplace config.
Same structural fix as test-plugins.yml: drop the `branches` allowlist
so the Stats Plugin tests run on any branch/PR touching plugins/stats/
or the workflow file itself.

Copy link
Copy Markdown
Member Author

CI Maintenance Agent — Failure Analysis (2026-04-12)

CI runs 24298790072 (test-plugins) and 24298782547 (test-stats) failed on this PR. The failures are not caused by the changes in this PR — this PR only removes 4 lines from workflow trigger blocks. Here is what's actually happening.

Why CI is failing

By removing the branches allowlist, the PR itself triggered CI to run on the fix/ci-workflow-trigger-broadening branch for the first time. That branch is based on fix/ci-type-errors-and-stale-test-date at commit 7e440fb7, which contains only a partial code fix:

Bug Fixed in base?
InstalledPluginEntry unused import in doctor.ts ✅ yes (c8561cc)
getSessionSummary stale date in db.test.ts ✅ yes (c8561cc)
removeGitignoreEntries unused import in conventions-integration.test.ts ❌ not yet
vi unused import in doctor.test.ts ❌ not yet
existsSync unused import in conventions-manager.ts ❌ not yet
Stale dates in integration.test.ts ❌ not yet
browser-use version mismatch (1.1.1 vs 1.1.2) ❌ not yet

The remaining 4 unfixed issues are exactly the TS6133 errors that cause test (20) to fail and the stale-date / version-mismatch issues that cause test (Stats) to fail. These are the same failures documented in issue #30.

How to unblock this PR

Merge PR #24 first (fix/ci-24065489776-ts-and-datesfix/ci-type-errors-and-stale-test-date).

PR #24 is fully green (7/7 checks ✅, run 24278705651) and fixes all the remaining issues. Once it lands on fix/ci-type-errors-and-stale-test-date, rebase or re-push this branch and CI should go green.

This PR's structural change (removing branches filters) is correct and necessary — the failures it exposed are real pre-existing bugs, not regressions introduced here.


Generated by CI maintenance agent


Generated by Claude Code

This was referenced Apr 12, 2026

Copy link
Copy Markdown
Member Author

CI Maintenance Agent — automated analysis (2026-04-15)

This PR's CI is currently failing. Here is the root-cause breakdown:

Failed runs

Run ID Workflow Job Conclusion Root cause
24298790072 Test Plugins test (20) failure TypeScript unused imports (TS6133: removeGitignoreEntries, vi, existsSync) in base branch code — tsc --noEmit fails under noUnusedLocals
24298790072 Test Plugins test (22) cancelled Cancelled after test (20) failed
24298790076 Test Stats Plugin test failure Stale hardcoded date 2026-03-26 in plugins/stats/tests/integration.test.ts — outside the 7/14-day rolling query windows used by getSessionSummary, getTopTools, getDurationTrend
24298782547 Test Stats Plugin test failure Same stale date issue (push trigger)

Why this PR itself can't fix these failures

This PR only changes workflow YAML files (removing branches allowlists from triggers). The code failures are inherited from the base branch fix/ci-type-errors-and-stale-test-date, which still contains the broken TypeScript imports and stale test dates.

This PR is superseded by PR #33

PR #33 (fix/ci-consolidated) is based on fix/ci-24065489776-ts-and-dates — which already has all code-level fixes — and adds the same trigger-broadening commit from this PR. All CI checks on PR #33 are green ✅.

Recommended action: Close this PR in favour of PR #33, which delivers the same trigger fix together with all the code fixes needed to make tests pass.


Generated by Claude Code

This was referenced Aug 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants