fix(ci): consolidated — TS imports, stale dates, browser-use version, unrestricted triggers - #33
Open
erudenko wants to merge 5 commits into
Open
Conversation
TypeScript type check (tsc --noEmit) fails on main with four TS6133/TS6196 errors — unused imports that were left behind after refactors: • conventions-integration.test.ts: removeGitignoreEntries (never called) • doctor.test.ts: vi (never used) • conventions-manager.ts: existsSync (never used after refactor) • doctor.ts: InstalledPluginEntry type (parameter removed) Stats tests (db.test.ts, integration.test.ts) were using the hardcoded date "2026-03-26" which has drifted outside the 7/14-day query windows, causing getSessionSummary, getTopTools and getDurationTrend tests to return zero results and fail assertions. Fix: replace hardcoded dates with dynamic TODAY/YESTERDAY/TWO_DAYS_AGO constants so the tests stay green regardless of when CI runs. Fixes CI runs: 24065489776, 24063290384, 24029941408, 24029941414 https://claude.ai/code/session_01Vc3jfA2et2zDDpenc4EcrW
main is now a dist-only orphan (4070f70) with no source code, so CI will never fire on main again. Add the source branch to the trigger list so this PR gets validated by CI. https://claude.ai/code/session_011jT6rDWtzsZphizRMFEp96
…st-date main is now a dist-only orphan (4070f70) with no source code, so CI will never fire on main again. Add the source branch to the trigger list so this PR gets validated by CI. https://claude.ai/code/session_011jT6rDWtzsZphizRMFEp96
…ce.json plugin.json already listed v1.1.2 (re-fix oneOf schema rejection from browser-use#4211), but marketplace.json was never updated — causing the marketplace-sync integration test to fail with a version mismatch error. Fixes CI run 24276607217 (test (22) — Run integration tests)."
Both test-plugins.yml and test-stats.yml had a hardcoded `branches` allowlist that restricted CI to only fire on `main` and `fix/ci-type-errors-and-stale-test-date`. Any other branch (fix, feature, etc.) was invisible to CI — only GitGuardian would fire. Remove the `branches` key entirely from both `push` and `pull_request` triggers in both workflow files. Path filters already ensure CI only runs when relevant files change, so there is no noise increase.
This was referenced Apr 12, 2026
Open
Open
Open
CI maintenance: 3 active failures on PR #32, 8 open fix PRs need triage — recommended merge path
#53
Open
This was referenced Aug 16, 2026
Open
Open
ci-maintenance: 18 unmerged fix PRs accumulating — automated agent feedback loop must be broken
#584
Open
Open
Open
This was referenced Aug 23, 2026
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR fixes
This consolidates all outstanding CI failures into a single, self-contained PR that is based on top of PR #24 (the comprehensive code fix) and adds the final workflow-trigger broadening from PR #32.
Failed runs addressed
tsc --noEmit— 3 unused TS importsRoot causes & fixes
1. Unused TypeScript imports (TS6133) — inherited from PR #24
tsc --noEmitfails undernoUnusedLocalsfor three imports left behind after refactors:tools/claudeup-core/src/__tests__/integration/conventions-integration.test.tsremoveGitignoreEntriestools/claudeup-core/src/__tests__/unit/doctor.test.tsvitools/claudeup-core/src/services/conventions-manager.tsexistsSyncFix: removed all three (carried in from PR #24 head).
2. Stale hardcoded test dates — inherited from PR #24
plugins/stats/tests/db.test.tsandintegration.test.tsused"2026-03-26"which is now 17 days old — outside the 7-day and 14-day rolling query windows used bygetSessionSummary,getTopTools, andgetDurationTrend. Those tests assertlength > 0/ specific counts and return zero rows.Fix: dynamic
TODAY/YESTERDAY/TWO_DAYS_AGOconstants (carried in from PR #24 head).3. browser-use version mismatch — inherited from PR #24
plugins/browser-use/plugin.jsonwas bumped tov1.1.2but.claude-plugin/marketplace.jsonwas left atv1.1.1. Themarketplace-syncintegration test catches exactly this drift.Fix:
marketplace.jsonbumped to1.1.2(carried in from PR #24 head).4. Hardcoded branch filters in workflow triggers — new commit in this PR
Both
test-plugins.ymlandtest-stats.ymlhad abranchesallowlist:Any branch not in that list (every new
fix/*orfeat/*branch) was invisible to CI — pushes and PRs only triggered GitGuardian. This is why PRs #22, #23, #28, #31, and #32 all lacked test CI runs.Fix: removed the
brancheskey entirely from both triggers in both files. Path filters already limit CI to relevant file changes, so there is no noise increase.Why PR #32 was still failing
PR #32 (
fix/ci-workflow-trigger-broadening) only changed the workflow YAML — it was stacked directly onfix/ci-type-errors-and-stale-test-date, which still had the broken TS imports and stale dates. CI ran (the trigger fix worked), but the tests themselves failed.This PR is branched from PR #24's head (
fix/ci-24065489776-ts-and-dates) so all code-level fixes are already present. The single new commit removes the branch filters.Supersedes
fix/ci-workflow-trigger-broadening) — same trigger fix but with all code fixes includedDoes NOT supersede
fix/ci-24065489776-ts-and-dates) — this PR is based directly on its head and includes all its changes plus the trigger broadening. If fix(ci): remove 3 unused TS imports + fix stale stats dates + re-enable CI triggers #24 is merged first, this PR's diff will shrink to just the two workflow-file changes.