Fix build workflow MFC/ATL installation and address reviewer feedback#15
Merged
Conversation
Closed
Co-authored-by: Mika3578 <58137747+Mika3578@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update GitHub workflows for automation and quality checks
Fix build workflow MFC/ATL installation and address reviewer feedback
Nov 10, 2025
Mika3578
marked this pull request as ready for review
November 10, 2025 19:18
There was a problem hiding this comment.
Pull Request Overview
This PR fixes build failures caused by missing MFC/ATL components and addresses reviewer feedback on workflow configurations. The changes ensure Windows builds can successfully compile by explicitly installing required Visual Studio components, and improve workflow stability by pinning action versions and correcting PowerShell command syntax.
- Explicitly installs MFC/ATL components via Chocolatey before building
- Pins trivy-action to version 0.28.0 for stability
- Fixes PowerShell Select-String syntax in code quality checks
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/build.yml |
Adds chocolatey installation of MFC/ATL components and formats executable size output to 2 decimal places |
.github/workflows/security-scan.yml |
Pins trivy-action to version 0.28.0 instead of using @master to prevent breaking changes |
.github/workflows/code-quality.yml |
Corrects Select-String PowerShell syntax to use -Path with directory and -Include for file patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build was failing with missing
atlbase.hand MFC library errors. The workflow assumed windows-latest runners include MFC/ATL by default, but these are optional components requiring explicit installation.Changes
Build Workflow
Security Scan Workflow
0.28.0instead of@masterto prevent breaking changesCode Quality Workflow
Select-Stringsyntax: use-Path dir -Include *.ext -Recurseinstead of-Path dir\*.ext -Recurse✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.