Skip to content

Fix build workflow MFC/ATL installation and address reviewer feedback #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mika3578 merged 2 commits into from
Nov 10, 2025
Merged

Fix build workflow MFC/ATL installation and address reviewer feedback #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
729b5c7
Initial plan
Copilot Nov 10, 2025
98dd779
Fix MFC/ATL installation and address reviewer comments
Copilot Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,16 @@ jobs:
- name: Install Visual Studio MFC/ATL Components
shell: pwsh
run: |
# Visual Studio already includes MFC/ATL in windows-latest runner
# Install MFC and ATL components required for building eMule
Write-Host "Installing Visual Studio MFC and ATL components..."
choco install visualstudio2022-workload-vctools --package-parameters "--add Microsoft.VisualStudio.Component.VC.ATL --add Microsoft.VisualStudio.Component.VC.ATLMFC" -y

# Verify installation
$vsPath = & "C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -latest -property installationPath
Write-Host "Visual Studio Path: $vsPath"
Write-Host "Checking MFC/ATL availability..."
if (Test-Path "$vsPath\VC\Tools\MSVC") {
$mfcPath = Get-ChildItem "$vsPath\VC\Tools\MSVC" -Directory | Select-Object -Last 1
Write-Host "MFC/ATL Path: $mfcPath"
Write-Host "MFC/ATL installed at: $mfcPath"
}

- name: Setup Visual Studio Developer Environment
Expand Down Expand Up @@ -79,5 +81,5 @@ jobs:
echo "Platform: ${{matrix.platform}}" >> $env:GITHUB_STEP_SUMMARY
if (Test-Path "srchybrid/${{matrix.configuration}}/emule.exe") {
$fileInfo = Get-Item "srchybrid/${{matrix.configuration}}/emule.exe"
echo "Executable Size: $($fileInfo.Length / 1MB) MB" >> $env:GITHUB_STEP_SUMMARY
echo "Executable Size: $([math]::Round($fileInfo.Length / 1MB, 2)) MB" >> $env:GITHUB_STEP_SUMMARY
}
4 changes: 2 additions & 2 deletions .github/workflows/code-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
echo "### Code Quality Checks :mag:" >> $env:GITHUB_STEP_SUMMARY

# Check for TODO comments
$todos = Select-String -Path srchybrid\*.cpp,srchybrid\*.h -Pattern "TODO|FIXME|HACK" -Recurse -ErrorAction SilentlyContinue
$todos = Select-String -Path srchybrid -Include *.cpp,*.h -Pattern "TODO|FIXME|HACK" -Recurse -ErrorAction SilentlyContinue
if ($todos) {
$todoCount = ($todos | Measure-Object).Count
echo "Found $todoCount TODO/FIXME/HACK comments" >> $env:GITHUB_STEP_SUMMARY
Expand All @@ -66,7 +66,7 @@ jobs:
}

# Check for hardcoded paths
$hardcodedPaths = Select-String -Path srchybrid\*.cpp -Pattern "C:\\\\|D:\\\\" -Recurse -ErrorAction SilentlyContinue
$hardcodedPaths = Select-String -Path srchybrid -Include *.cpp -Pattern "C:\\\\|D:\\\\" -Recurse -ErrorAction SilentlyContinue
if ($hardcodedPaths) {
$pathCount = ($hardcodedPaths | Measure-Object).Count
echo ":warning: Found $pathCount potential hardcoded paths" >> $env:GITHUB_STEP_SUMMARY
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/security-scan.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
fetch-depth: 0

- name: Run Trivy vulnerability scanner
uses: aquasecurity/trivy-action@master
uses: aquasecurity/trivy-action@0.28.0
with:
scan-type: 'fs'
scan-ref: '.'
Expand Down