Use the remote user's login shell - #2
Open
nickadminroot wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bash --rcfile ...command with the remote account's executable$SHELL, falling back to the passwd login shell and/bin/sh.zshenv,.zprofile,.zshrc, and.zloginin order without duplicate sourcing, and restore the originalZDOTDIRstateupdate-environmentvariables alongside the VS Code variablessource-fileinstead of destroying persistent sessions withkill-serverExisting panes intentionally keep the shell process they were created with; newly created panes use the selected login shell.
For Bash, profiles that customize
PROMPT_COMMANDshould preserve its inherited value so Persisterm can continue refreshing VS Code IPC variables after reconnects.Testing
npm run lintnpm test— 8/8 passing, including real tmux panes for Bash, Zsh, and Fishnpm audit --audit-level=high— 0 vulnerabilitiesnpm run package -- --out persisterm-user-shell.vsixCloses #1