Update ast-grep rules to use the latest version - #425
Merged
Conversation
skejserjensen
requested review from
CGodiksen and
chrthomsen
and
a lite review from Copilot
August 22, 2026 11:15
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ast-grep rules and workflow configuration for compatibility with newer releases.
Changes:
- Adds
#[property_test]support to test naming checks. - Updates punctuation matching.
- Removes the pinned ast-grep version from CI.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Summary |
|---|---|
rules/test_not_named_test.yml |
Adds property-test attribute support. |
rules/missing_punctuation.yml |
Adjusts punctuation matching. |
.github/workflows/ast-grep-scan.yml |
Critical issue: latest is not a valid action reference, so the scan job will fail. Use a valid ref such as @v1. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
CGodiksen
approved these changes
Aug 23, 2026
skejserjensen
force-pushed
the
dev/update-ast-grep
branch
from
August 25, 2026 09:26
710f8a3 to
c19f9ab
Compare
chrthomsen
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the
ast-greprules so they work with the latest version ofast-grepto fix #192. Theast-grepGitHub Action has also been updated to always use the latest version ofast-grep.