Skip to content

Update proto file and use new lossless error bound - #54

Merged
CGodiksen merged 2 commits into
mainfrom
dev/lossless-error-bound
Sep 10, 2025
Merged

Update proto file and use new lossless error bound#54
CGodiksen merged 2 commits into
mainfrom
dev/lossless-error-bound

Conversation

@CGodiksen

Copy link
Copy Markdown
Collaborator

This PR updates the Apache Arrow Flight tester to match the latest changes from https://github.com/ModelarData/ModelarDB-RS.

Note that this PR should not be merged before ModelarData/ModelarDB-RS#350 is merged.

@CGodiksen CGodiksen self-assigned this Sep 9, 2025
@CGodiksen
CGodiksen requested a review from Copilot September 9, 2025 18:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Apache Arrow Flight tester to use a new "lossless" error bound type and removes retention period configuration parameters, synchronizing with changes from ModelarDB-RS.

  • Adds LOSSLESS error bound type to protocol definitions
  • Removes retention_period_in_seconds from Configuration messages
  • Updates test code to use lossless error bounds instead of absolute

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
protocol.proto Adds LOSSLESS error bound type and removes retention period configuration
protocol_pb2.py Updates generated Python protobuf code with new serialized protocol definitions
protocol_pb2.pyi Updates Python type stubs to reflect protocol changes
common.py Changes test table creation to use lossless error bounds

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Apache-Arrow-Flight-Tester/common.py
@CGodiksen
CGodiksen merged commit 2173fb0 into main Sep 10, 2025
@CGodiksen
CGodiksen deleted the dev/lossless-error-bound branch September 10, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants