Skip to content

Update proto file and use new lossless error bound #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CGodiksen merged 2 commits into from
Sep 10, 2025
Merged

Update proto file and use new lossless error bound #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5975570
Update proto file with newest changes
CGodiksen Sep 9, 2025
59f0374
Use lossless error bound type
CGodiksen Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Apache-Arrow-Flight-Tester/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,8 @@ def create_test_tables_from_metadata(self):

time_series_table_schema = get_time_series_table_schema()

absolute = protocol_pb2.TableMetadata.TimeSeriesTableMetadata.ErrorBound.Type.ABSOLUTE
error_bounds = [protocol_pb2.TableMetadata.TimeSeriesTableMetadata.ErrorBound(value=0, type=absolute)
lossless = protocol_pb2.TableMetadata.TimeSeriesTableMetadata.ErrorBound.Type.LOSSLESS
Comment thread
CGodiksen marked this conversation as resolved.
error_bounds = [protocol_pb2.TableMetadata.TimeSeriesTableMetadata.ErrorBound(value=0, type=lossless)
for _ in range(len(time_series_table_schema))]

generated_column_expressions = [b'' for _ in range(len(time_series_table_schema))]
Expand Down
11 changes: 4 additions & 7 deletions Apache-Arrow-Flight-Tester/protobuf/protocol.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ message TableMetadata {
enum Type {
ABSOLUTE = 0;
RELATIVE = 1;
LOSSLESS = 2;
}
Type type = 1;
float value = 2;
Expand Down Expand Up @@ -107,17 +108,14 @@ message Configuration {
// The number of seconds between each transfer of data to the remote object store.
optional uint64 transfer_time_in_seconds = 5;

// The number of seconds to retain deleted data in storage before it can be removed by vacuum.
uint64 retention_period_in_seconds = 6;

// Number of threads to allocate for converting multivariate time series to univariate time series.
uint32 ingestion_threads = 7;
uint32 ingestion_threads = 6;

// Number of threads to allocate for compressing univariate time series to segments.
uint32 compression_threads = 8;
uint32 compression_threads = 7;

// Number of threads to allocate for writing segments to a local and/or remote data folder.
uint32 writer_threads = 9;
uint32 writer_threads = 8;
}

// Request to update the configuration of a ModelarDB node.
Expand All @@ -128,7 +126,6 @@ message UpdateConfiguration {
COMPRESSED_RESERVED_MEMORY_IN_BYTES = 2;
TRANSFER_BATCH_SIZE_IN_BYTES = 3;
TRANSFER_TIME_IN_SECONDS = 4;
RETENTION_PERIOD_IN_SECONDS = 5;
}

// Setting to update in the configuration.
Expand Down
22 changes: 11 additions & 11 deletions Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 4 additions & 6 deletions Apache-Arrow-Flight-Tester/protobuf/protocol_pb2.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,10 @@ class TableMetadata(_message.Message):
__slots__ = ()
ABSOLUTE: _ClassVar[TableMetadata.TimeSeriesTableMetadata.ErrorBound.Type]
RELATIVE: _ClassVar[TableMetadata.TimeSeriesTableMetadata.ErrorBound.Type]
LOSSLESS: _ClassVar[TableMetadata.TimeSeriesTableMetadata.ErrorBound.Type]
ABSOLUTE: TableMetadata.TimeSeriesTableMetadata.ErrorBound.Type
RELATIVE: TableMetadata.TimeSeriesTableMetadata.ErrorBound.Type
LOSSLESS: TableMetadata.TimeSeriesTableMetadata.ErrorBound.Type
TYPE_FIELD_NUMBER: _ClassVar[int]
VALUE_FIELD_NUMBER: _ClassVar[int]
type: TableMetadata.TimeSeriesTableMetadata.ErrorBound.Type
Expand All @@ -91,13 +93,12 @@ class TableMetadata(_message.Message):
def __init__(self, normal_table: _Optional[_Union[TableMetadata.NormalTableMetadata, _Mapping]] = ..., time_series_table: _Optional[_Union[TableMetadata.TimeSeriesTableMetadata, _Mapping]] = ...) -> None: ...

class Configuration(_message.Message):
__slots__ = ("multivariate_reserved_memory_in_bytes", "uncompressed_reserved_memory_in_bytes", "compressed_reserved_memory_in_bytes", "transfer_batch_size_in_bytes", "transfer_time_in_seconds", "retention_period_in_seconds", "ingestion_threads", "compression_threads", "writer_threads")
__slots__ = ("multivariate_reserved_memory_in_bytes", "uncompressed_reserved_memory_in_bytes", "compressed_reserved_memory_in_bytes", "transfer_batch_size_in_bytes", "transfer_time_in_seconds", "ingestion_threads", "compression_threads", "writer_threads")
MULTIVARIATE_RESERVED_MEMORY_IN_BYTES_FIELD_NUMBER: _ClassVar[int]
UNCOMPRESSED_RESERVED_MEMORY_IN_BYTES_FIELD_NUMBER: _ClassVar[int]
COMPRESSED_RESERVED_MEMORY_IN_BYTES_FIELD_NUMBER: _ClassVar[int]
TRANSFER_BATCH_SIZE_IN_BYTES_FIELD_NUMBER: _ClassVar[int]
TRANSFER_TIME_IN_SECONDS_FIELD_NUMBER: _ClassVar[int]
RETENTION_PERIOD_IN_SECONDS_FIELD_NUMBER: _ClassVar[int]
INGESTION_THREADS_FIELD_NUMBER: _ClassVar[int]
COMPRESSION_THREADS_FIELD_NUMBER: _ClassVar[int]
WRITER_THREADS_FIELD_NUMBER: _ClassVar[int]
Expand All @@ -106,11 +107,10 @@ class Configuration(_message.Message):
compressed_reserved_memory_in_bytes: int
transfer_batch_size_in_bytes: int
transfer_time_in_seconds: int
retention_period_in_seconds: int
ingestion_threads: int
compression_threads: int
writer_threads: int
def __init__(self, multivariate_reserved_memory_in_bytes: _Optional[int] = ..., uncompressed_reserved_memory_in_bytes: _Optional[int] = ..., compressed_reserved_memory_in_bytes: _Optional[int] = ..., transfer_batch_size_in_bytes: _Optional[int] = ..., transfer_time_in_seconds: _Optional[int] = ..., retention_period_in_seconds: _Optional[int] = ..., ingestion_threads: _Optional[int] = ..., compression_threads: _Optional[int] = ..., writer_threads: _Optional[int] = ...) -> None: ...
def __init__(self, multivariate_reserved_memory_in_bytes: _Optional[int] = ..., uncompressed_reserved_memory_in_bytes: _Optional[int] = ..., compressed_reserved_memory_in_bytes: _Optional[int] = ..., transfer_batch_size_in_bytes: _Optional[int] = ..., transfer_time_in_seconds: _Optional[int] = ..., ingestion_threads: _Optional[int] = ..., compression_threads: _Optional[int] = ..., writer_threads: _Optional[int] = ...) -> None: ...

class UpdateConfiguration(_message.Message):
__slots__ = ("setting", "new_value")
Expand All @@ -121,13 +121,11 @@ class UpdateConfiguration(_message.Message):
COMPRESSED_RESERVED_MEMORY_IN_BYTES: _ClassVar[UpdateConfiguration.Setting]
TRANSFER_BATCH_SIZE_IN_BYTES: _ClassVar[UpdateConfiguration.Setting]
TRANSFER_TIME_IN_SECONDS: _ClassVar[UpdateConfiguration.Setting]
RETENTION_PERIOD_IN_SECONDS: _ClassVar[UpdateConfiguration.Setting]
MULTIVARIATE_RESERVED_MEMORY_IN_BYTES: UpdateConfiguration.Setting
UNCOMPRESSED_RESERVED_MEMORY_IN_BYTES: UpdateConfiguration.Setting
COMPRESSED_RESERVED_MEMORY_IN_BYTES: UpdateConfiguration.Setting
TRANSFER_BATCH_SIZE_IN_BYTES: UpdateConfiguration.Setting
TRANSFER_TIME_IN_SECONDS: UpdateConfiguration.Setting
RETENTION_PERIOD_IN_SECONDS: UpdateConfiguration.Setting
SETTING_FIELD_NUMBER: _ClassVar[int]
NEW_VALUE_FIELD_NUMBER: _ClassVar[int]
setting: UpdateConfiguration.Setting
Expand Down