Harden RTM template parsing to prevent DoS on malformed/unbounded tx data#25
Merged
MoneroOcean merged 1 commit intoMay 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
MAX_TEMPLATE_TRANSACTIONS = 5000and validate the decoded transaction count, rejecting counts outside the allowed range.blob_in.lengthand throw on out-of-range offsets to avoid reading past the buffer.rtm.readTransactionintry/catchand validate the returnedparsed.offsetto ensure parsed sizes are sane before advancing.convertRtmBlobandconstructNewRtmBlobwithtry/catcharoundupdate_merkle_root_hashso malformed daemon templates do not crash the process while preserving return shapes.Testing
node -c index.js, which succeeded.Codex Task