Skip to content

Harden RTM template parsing to prevent DoS on malformed/unbounded tx data #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MoneroOcean merged 1 commit into from
May 29, 2026
Merged

Harden RTM template parsing to prevent DoS on malformed/unbounded tx data #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ const fastMerkleRoot = require('merkle-lib/fastRoot');
const { BASE_DIFF, parseBigInt } = require('./bigint');
const rtm = require('./rtm');

const MAX_TEMPLATE_TRANSACTIONS = 5000;

function scriptCompile(addrHash) {
return bitcoin.script.compile([
bitcoin.opcodes.OP_DUP,
Expand Down Expand Up @@ -178,11 +180,25 @@ module.exports.RavenBlockTemplate = function(rpcData, poolAddress) {
function update_merkle_root_hash(offset, payload, blob_in, blob_out, transaction_hash_func, detectWitness) {
const nTransactions = varuint.decode(blob_in, offset);
offset += varuint.decode.bytes;
if (nTransactions < 1 || nTransactions > MAX_TEMPLATE_TRANSACTIONS) {
throw new Error('Invalid transaction count in block template');
}
let transactions = [];
for (let i = 0; i < nTransactions; ++i) {
if (offset >= blob_in.length) {
throw new Error('Invalid transaction offset in block template');
}
let tx;
if (payload) {
const parsed = rtm.readTransaction(blob_in, offset, true);
let parsed;
try {
parsed = rtm.readTransaction(blob_in, offset, true);
} catch (err) {
throw new Error('Unable to parse transaction from block template');
}
if (!parsed || parsed.offset <= offset || parsed.offset > blob_in.length) {
throw new Error('Invalid transaction size in block template');
}
tx = parsed.transaction;
offset = parsed.offset;
if (i + 1 < nTransactions) {
Expand Down Expand Up @@ -253,7 +269,11 @@ module.exports.RtmBlockTemplate = function(rpcData, poolAddress) {

module.exports.convertRtmBlob = function(blobBuffer) {
let header = blobBuffer.slice(0, 80);
update_merkle_root_hash(80, true, blobBuffer, header, transaction_hash, true);
try {
update_merkle_root_hash(80, true, blobBuffer, header, transaction_hash, true);
} catch (err) {
// Keep process alive when daemon returns malformed RTM template data.
}
return header;
};

Expand All @@ -264,7 +284,11 @@ module.exports.convertKcnBlob = function(blobBuffer) {
};

module.exports.constructNewRtmBlob = function(blockTemplate, nonceBuff) {
update_merkle_root_hash(80, true, blockTemplate, blockTemplate, transaction_hash, true);
try {
update_merkle_root_hash(80, true, blockTemplate, blockTemplate, transaction_hash, true);
} catch (err) {
// Keep process alive when daemon returns malformed RTM template data.
}
nonceBuff.copy(blockTemplate, 76, 0, 4);
return blockTemplate;
};
Expand Down
Loading