Convert remaining MainGameScreen visuals to NUI#665
Merged
BenjaminAmos merged 3 commits intoMovingBlocks:nui-ported-screensfrom Oct 31, 2022
Merged
Conversation
This was referenced Sep 26, 2022
This was referenced Oct 12, 2022
bb17c4b to
7281418
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request converts all remaining visual functionality of
MainGameScreento use NUI instead. This does not cover auxiliary classes, such asBorderDrawerandZoneNameAnnouncerbut does includeWarnDrawer. Most of the not covered classes render rotated images, which is not supported under NUI (and so useUiDrawerdirectly instead).The original
MainGameScreenclass remains for now, due to other dependencies in the code that rely on it, such as input handling.This pull request also includes a bug-fix for retrieving item examples in
ItemManager.Testing
Warnings
Imperial Smallis recommended for this)Armour
Shield
Health
Enemies
Stats Bars
Health Bar
Shield Bar
Ammunition Bar
Miscellaneous
Potential Future Improvements
UIWarnDrawernotifications are not the most visually pleasant. Better placement and design is needed but for now I've tried to retain most lf the original appearance and behaviour.UIWarnDrawernotifications start from the middle of the screen on Android, which shouldn't really be the case.Breaking Changes
GameScreens#mainGameScreenvariable has been re-named toGameScreens#oldMainGameScreen.GameScreens#mainGameScreennow points to the NUI version ofMainGameScreeninstead.Notes
EmptyIfInvisibleContainer,UIBackingBoxandUILabelledIcon) #664.