Skip to content

Chore(#88): Add menhaden workflow - #105

Open
atyrell3 wants to merge 10 commits into
devfrom
chore/i88-add-menhaden
Open

atyrell3 wants to merge 10 commits into
devfrom
chore/i88-add-menhaden

Conversation

@atyrell3

@atyrell3 atyrell3 commented Oct 8, 2026

Copy link
Copy Markdown
Member

Justification

New pipeline for adding menhaden data from publicly available FOSS and ACCSP data sources. Currently relies on manual download to data-raw, can be updated with API integration. Note that 2025 data is not yet complete, waiting on ACCSP data to update later this month.

Fixes #88

Types of changes

What types of changes does this pull request introduce? Put an x in the boxes that apply.
This will inform the new release number.

  • Fix (non-breaking change which fixes a bug)
  • Feature (non-breaking change which adds or changes functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other change (if none of the other choices apply)

Reviewer instructions

Verify that function runs:

get_menhaden_data(foss_region_path = here::here("data-raw\\FOSS_landings.csv"), 
foss_nc_path = here::here("data-raw\\FOSS_landings_NC.csv"), 
accsp_path =here::here("data-raw\\accsp_menhaden_SOE2027.csv")) 

Formatting

This repo contains an air.toml file that automatically formats code to a set of standards.
It is preferred that contributors and reviewers install the Air formatting tool.
Code submitted in this pull request will be automatically checked for correct formatting.

@andybeet andybeet changed the title Chore/i88 add menhaden Chore(#88): Add menhaden workflow Oct 9, 2026
@andybeet andybeet linked an issue Oct 9, 2026 that may be closed by this pull request
@andybeet
andybeet self-requested a review October 9, 2026 21:45

@andybeet andybeet left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a proposed new workflow. We need it, so thanks for adding it.

However the function is not structured in anyway like every other function in this repo. It needs to be refactored to take filepaths as arguments. It needs also needs workflow script in data raw + other small documentation (see this contributing file). Easier to build pkgdown locally to view it

The static file should not be committed directly to the repo but put in the folder we all agreed static files would be added to. This is on the network drive.

EDIT: we have been using standardized names for the path arguments (yes, they are a mouthful and probably not great, but until we change them all we should be consitent). For example input_path_foss.

@andybeet andybeet left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Duplicated message. Apologies

@jcaracappa1

Copy link
Copy Markdown
Collaborator

Agreed on the static file and workflows. However, it looks like the function uses file path arguments, so it should work like the others

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 2025 menhaden data

3 participants