Repository navigation
Conversation
There was a problem hiding this comment.
This is a proposed new workflow. We need it, so thanks for adding it.
However the function is not structured in anyway like every other function in this repo. It needs to be refactored to take filepaths as arguments. It needs also needs workflow script in data raw + other small documentation (see this contributing file). Easier to build pkgdown locally to view it
The static file should not be committed directly to the repo but put in the folder we all agreed static files would be added to. This is on the network drive.
EDIT: we have been using standardized names for the path arguments (yes, they are a mouthful and probably not great, but until we change them all we should be consitent). For example input_path_foss.
|
Agreed on the static file and workflows. However, it looks like the function uses file path arguments, so it should work like the others |
Justification
New pipeline for adding menhaden data from publicly available FOSS and ACCSP data sources. Currently relies on manual download to
data-raw, can be updated with API integration. Note that 2025 data is not yet complete, waiting on ACCSP data to update later this month.Fixes #88
Types of changes
What types of changes does this pull request introduce? Put an
xin the boxes that apply.This will inform the new release number.
Reviewer instructions
Verify that function runs:
Formatting
This repo contains an
air.tomlfile that automatically formats code to a set of standards.It is preferred that contributors and reviewers install the Air formatting tool.
Code submitted in this pull request will be automatically checked for correct formatting.