Skip to content

Updates for windio 2.1#460

Open
dzalkind wants to merge 12 commits intoNLRWindSystems:developfrom
dzalkind:windio2p1
Open

Updates for windio 2.1#460
dzalkind wants to merge 12 commits intoNLRWindSystems:developfrom
dzalkind:windio2p1

Conversation

@dzalkind
Copy link
Collaborator

Purpose

Conform to latest windio schema, v2.1

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

  • I have run existing tests which pass locally with my changes
  • I have added new tests or examples that prove my fix is effective or that my feature works
  • I have added necessary documentation

# Compute the number of DLCs that will be run
DLCs = self.modeling_options['DLC_driver']['DLCs']
# Initialize the DLC generator
cut_in = self.wt_init['control']['supervisory']['Vin']
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not such of fan of this. I made these tables in ROSCO, which uses some defined cut-in wind speed, sometimes coming from wisdem/weis, so it's a bit circular.

I would vote for a cut-in/cut-out wind speed explicitly defined somewhere. I prototyped an addition to the control geometry schema in WISDEM if we want it there, but I also think it could go under assembly. Thoughts?

@dzalkind dzalkind mentioned this pull request Mar 3, 2026
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant