Repository navigation
Feature(#401): Add set.seed for short term trends - #471
Merged
Merged
Conversation
…s a bootstrap method, this ensures that plots will be reproducible
BBeltz1
approved these changes
Oct 7, 2026
BBeltz1
left a comment
Collaborator
There was a problem hiding this comment.
this looks good, thanks abby! i'm not seeing any variation in the output of several runs of ecodata::plot_comdat(varName = "revenue", n = 10). the checks that are failing are expected and are unrelated to this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Justification
Short term trend plotting was not reproducible last year, resulting in trend lines appearing/disappearing when plots were regenerated. This is caused by the bootstrapping in the
arfitmethods used to fit the short-term trend.Fixes #401
Types of changes
Reviewer instructions
ecodata::plot_**call withn = 10multiple times to ensure short-term trend (or lack thereof) is reproducible. Suggest to useplot_comdat(varName = "revenue", n = 10)as this gave us trouble last year.Formatting
This repo contains an
air.tomlfile that automatically formats code to a set of standards.It is preferred that contributors and reviewers install the Air formatting tool.
Code submitted in this pull request will be automatically checked for correct formatting.