Conversation
✅ Deploy Preview for celebrated-malasada-385661 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for nubook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@JosephusPaye thoughts on using PageFind? I figured this might be better than Algolia as it's less effort to maintain with people changing. I think the search has been broken for a long time, at least a year if not longer. From what I understand, there's an account linked to the Algolia key and that's where it needs to be fixed? imo NUbot's account burden is pretty large atm and it might be better to limit it. |
|
Yeah I think it's a great idea to have something self-hosted if possible, to remove the third-party service dependency. Not familiar with How are you finding the quality of the results when searching? |
|
@JosephusPaye overall it seems fine, most relevant comes up at the top and it does partial word matches similar to what we have now. Does the job imo. The styling isn't as nice, but I suspect it can be improved. |
|
Nice, I just checked and the results appear good enough. I don't like that it doesn't show the NUbook chapter title (maybe there's a way to include this when building the index?) or link results to specific sections on the page. I noticed the styling issues as well. Here's a list if it helps:
Other minor styling improvements:
I had an minor issue scrolling the result list on mobile (iPad) as it kept trying to scroll the background page instead of the result list. Can consistently reproduce there but not on Firefox on Android. |
PR description here.
https://deploy-preview-361--nubook.netlify.app/