Fix usage of dask-cuda in pip constraints - #23516
Conversation
Pip does not allow constraints to have extras. `depends_on_dask_cuda` previously had extras depending on the CUDA version. Remove the extras and allow the `cuda_version` dependency set to install the CUDA libraries instead.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe ChangesDask-CUDA dependency outputs
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jameslamb
left a comment
There was a problem hiding this comment.
I don't understand this at all. What is the "bug" you're referring to here?
Including the relevant context (as a link or text) would help. I don't understand the problem this PR is trying to solve.
jameslamb
left a comment
There was a problem hiding this comment.
These changes look fine and I understand how they solve the core problem. If this passes CI, go ahead and merge it.
|
/merge |
|
/merge |
Description
Pip does not allow constraints to have extras.
depends_on_dask_cudapreviously had extras depending on the CUDA version, and as a result, the constraint file containeddask-cuda[cu12]. As a result, we saw the following error:Remove the extras in the constraints and allow the other dependencies to install the CUDA libraries instead.
This bug happened at least partly as a result of #21671.
Context:
https://github.com/rapidsai/cudf/actions/runs/30818064363/job/91710572211?pr=23472#step:13:86
https://github.com/rapidsai/cudf/actions/runs/30671159887/job/91293198335#step:13:95
Checklist