fix: [apply-cuda-memory-limits] exit gracefully on oci spec load failure - #2103
Merged
Merged
Conversation
Coverage Report for CI Build 35126854839Coverage decreased (-0.003%) to 44.087%Details
Uncovered Changes
Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
cdesiniotis
approved these changes
Sep 16, 2026
With this fix, containers started with "userns --nomap" no longer fail as the OCI spec load operation is no longer non-blocking. This is required as the containers with "userns --nomap" fail even if they don't set the cuda memory limits environment variables. Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
cuda-mem-limits-silent-fail
branch
from
September 16, 2026 17:13
8d00324 to
1e5fb48
Compare
Contributor
Author
|
@cdesiniotis Thanks for the approve. Just fixed some typos in the commit description. |
tariq1890
enabled auto-merge
September 16, 2026 17:14
Contributor
Author
|
/cherry-pick release-1.20 |
henry118
reviewed
Sep 16, 2026
henry118
left a comment
henry118
left a comment
Member
There was a problem hiding this comment.
curious what led this change? previously we didn't expect the permission issue...
Contributor
Author
|
After running a podman container with |
Member
This appears to be a wrong path rather than permission issues? |
|
🤖 Backport PR created for |
Member
|
Opened PR containers/crun#2261 which should address this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this fix, containers started with "usens --nomap" no longer fail as the OCI spec load operation is no longer non-blocking. This is required as the containers with "users --nomap" fail even if they don't set the cuda memory limits environment variables.