Skip to content

[release-1.20] fix: [apply-cuda-memory-limits] exit gracefully on oci spec load failure - #2104

Merged
cdesiniotis merged 1 commit into
release-1.20from
backport-2103-to-release-1.20
Sep 16, 2026
Merged

cdesiniotis merged 1 commit into
release-1.20from
backport-2103-to-release-1.20

Conversation

@github-actions

Copy link
Copy Markdown

🤖 Automated backport of #2103 to release-1.20

✅ Cherry-pick completed successfully with no conflicts.

Original PR: #2103
Original Author: @tariq1890

Cherry-picked commits (1):

  • 1e5fb48 fix: [apply-cuda-memory-limits] exit gracefully on oci spec load failure

This backport was automatically created by the backport bot.

With this fix, containers started with "userns --nomap" no longer fail as
the OCI spec load operation is no longer non-blocking. This is required as
the containers with "userns --nomap" fail even if they don't set the cuda
memory limits environment variables.

Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
(cherry picked from commit 1e5fb48)
@copy-pr-bot

copy-pr-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tariq1890

Copy link
Copy Markdown
Contributor

/ok to test 99d1efb

@coveralls

coveralls commented Sep 16, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 35137579073

Coverage decreased (-0.004%) to 44.117%

Details

  • Coverage decreased (-0.004%) from the base build.
  • Patch coverage: 2 uncovered changes across 1 file (0 of 2 lines covered, 0.0%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
cmd/nvidia-cdi-hook/apply-cuda-memory-limits/apply-cuda-memory-limits.go 2 0 0.0%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
cmd/nvidia-cdi-hook/apply-cuda-memory-limits/apply-cuda-memory-limits.go 1 6.84%

Coverage Stats

Coverage Status
Relevant Lines: 13693
Covered Lines: 6041
Line Coverage: 44.12%
Coverage Strength: 0.44 hits per line

💛 - Coveralls

@cdesiniotis
cdesiniotis merged commit db2e439 into release-1.20 Sep 16, 2026
21 checks passed
@cdesiniotis
cdesiniotis deleted the backport-2103-to-release-1.20 branch September 16, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants