Conversation
newDevices advanced its index for every id while the lookup map kept one entry per distinct id, so List returned an empty string in the slot a repeated id left behind. In cdi mode the empty entry became a request for nvidia.com/gpu=none and the container failed to start. Signed-off-by: Jeff Lenamon <jlenamon@gmail.com>
lenamonj
requested review from
cdesiniotis,
henry118 and
tariq1890
as code owners
September 20, 2026 04:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A device id repeated in the visible devices request, for example
NVIDIA_VISIBLE_DEVICES=0,0or the same GPU in bothDOCKER_RESOURCE_GPUSandDOCKER_RESOURCE_GPUS_ADDITIONAL, puts an empty string inVisibleDevices.List(). Incdimode container creation then fails withunresolvable CDI devices nvidia.com/gpu=none.newDevicesadvanced its index for every id while the lookup map kept one entry per distinct id. It now skips an id it has already indexed, so each device is listed once, in first-seen order.Checklist
make test)make lint)Testing
Two cases added to
TestGetDevicesFromEnvvar; both fail on main and pass with the change. Also rannvidia-container-runtime createincdimode against a fixture CDI spec and a stub runc on a host without a GPU:NVIDIA_VISIBLE_DEVICES=0,0fails on main and succeeds with the change.