Skip to content

fix: return a repeated visible device once #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lenamonj wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −0
Open

fix: return a repeated visible device once #2108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions internal/config/image/cuda_image_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,22 @@ func TestGetDevicesFromEnvvar(t *testing.T) {
},
expectedDevices: []string{anotherGPUID},
},
{
description: "repeated device in NVIDIA_VISIBLE_DEVICES is returned once",
env: map[string]string{
EnvVarNvidiaVisibleDevices: gpuID + "," + anotherGPUID + "," + gpuID,
},
expectedDevices: []string{gpuID, anotherGPUID},
},
{
description: "device repeated across swarm resource envvars is returned once",
preferredVisibleDeviceEnvVars: []string{"DOCKER_RESOURCE_GPUS", "DOCKER_RESOURCE_GPUS_ADDITIONAL"},
env: map[string]string{
"DOCKER_RESOURCE_GPUS": gpuID,
"DOCKER_RESOURCE_GPUS_ADDITIONAL": gpuID,
},
expectedDevices: []string{gpuID},
},
}

for _, tc := range tests {
Expand Down
3 changes: 3 additions & 0 deletions internal/config/image/devices.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,9 @@ func newDevices(idOrCommaSeparated ...string) devices {
i := 0
for _, commaSeparated := range idOrCommaSeparated {
for id := range strings.SplitSeq(commaSeparated, ",") {
if _, exists := lookup[id]; exists {
continue
}
lookup[id] = i
i++
}
Expand Down