Drop allow_macos_failure now that the macOS segfault is fixed - #70
Merged
Conversation
The macOS pybind11 module segfault (scf-macos-pybind11-segfault.md) is fixed upstream via NWChemEx/.github#189 (Python_FIND_STRATEGY=LOCATION), verified 4/4 passing on both compiler legs. macOS should now be a real merge-blocking signal like every other platform/job.
test_pip_build's macOS gcc-14 leg fails deterministically for an unrelated, pre-existing reason (meson can't detect Homebrew gcc-14's linker while building numpy from source -- "Unable to detect linker for compiler `gcc-14 -Wl,--version`"), not the pybind11 segfault fixed by NWChemEx/.github#189. That fix only touches test_cmake_build's Configure step, so dropping allow_macos_failure from test_pip_build too was premature -- confirmed via this PR's own CI, which surfaced the gcc-14 failure again once unmasked. Keeping it dropped for test_cmake_build, which is genuinely fixed and verified (4/4 tests passing on both compiler legs).
numpy<2 was capped unconditionally to work around a manylinux2014/GCC-ABI
constraint that only exists on Linux. On macOS it had the opposite effect:
numpy<2's newest release (1.26.4) has no cp314 wheel, so pip fell back to
building it from source, which fails distinctly there -- Homebrew's gcc-14
has no bundled linker and shells out to Apple's system ld, and meson's
linker-detection probe (`gcc-14 -Wl,--version`) doesn't understand current
macOS/Xcode's linker ("ld: unknown options: --version"). That's the
test_pip_build (macos-14, gcc-14) failure allow_macos_failure has been
masking.
Scope the cap to sys_platform == 'linux' via a PEP 508 marker and leave
macOS unconstrained, so it resolves a real numpy>=2 wheel instead of
falling back to a source build at all -- sidesteps the linker-probe issue
entirely rather than working around it.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scf-macos-pybind11-segfault.mdis fixed upstream via NWChemEx/.github#189 (Python_FIND_STRATEGY=LOCATION), already merged.macos-14compiler legs (clang-18,gcc-14), including the C++ binaries that embed their own Python interpreter.allow_macos_failure: "true"workaround (added in #188) from bothpull_request.yamlandnightly.yamlso macOS is a real merge-blocking signal again, same as every other platform/job.Test plan
test_cmake_build/test_pip_buildpassing normally (not just running-but-ignored).🤖 Generated with Claude Code