fix: skip setup data restore on linux#171
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@nat-openclaw can you deep review the code and make sure there's no windows errors? /model gpt |
|
|
Deep-checked the Windows updater path and didn’t find a regression from this change.
Checks run:
All passed. I didn’t make any code changes or commit anything. |
|
@nat-openclaw can you investigate too why OGI after updating the setup, doesn't stay on that screen and instead drops you into the main menu for like a second then does the closing it's supposed to? |
|
When a setup update triggers shutdown, skip loading the main UI so users see the update status until process.exit() runs. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Yep — I found the flash. The updater was scheduling shutdown, but startup kept going, so OGI was loading the main menu into the same window for a moment before exit. I changed the startup flow to detect when an installer/setup update is already in progress, keep the splash screen up, and skip loading the main UI until shutdown happens. This should cover both Linux and Windows, and it doesn’t change the Linux backup/restore fix from this PR. Checked with |
|
@nat-openclaw fix plz opengameinstaller-gui typecheck: src/electron/updater.ts(27,10): error TS2440: Import declaration conflicts with local declaration of '__dirname'. |
|
I’m working on this and will keep this comment updated. Target: PR #171
React to this comment with 👎 to cancel the run. |
Closes #170\n\n## Summary\n- skip setup data backups during Linux setup updates\n- skip restoring stale setup backups on Linux and delete the temp backup folder instead\n- keep the Windows backup/restore and addon dependency reinstall path intact\n\n## Checks\n- node --check application/src/electron/updater.ts\n- node --check application/src/electron/startup.ts\n\nNote: bun is not installed in this environment, and npm install cannot handle the repo's workspace:* dependencies, so the application typecheck could not be run locally.