Skip to content

[ADD][15.0] passport_expiration#1339

Merged
OCA-git-bot merged 3 commits into
OCA:15.0from
yankinmax:add-passport_expiration
Sep 23, 2024
Merged

[ADD][15.0] passport_expiration#1339
OCA-git-bot merged 3 commits into
OCA:15.0from
yankinmax:add-passport_expiration

Conversation

@yankinmax
Copy link
Copy Markdown

@leemannd
Copy link
Copy Markdown
Contributor

leemannd commented Apr 3, 2024

Technically the code is good, but we loos the git history. I think this should be respected

@yankinmax
Copy link
Copy Markdown
Author

@leemannd IDK how to transfer git commit through different submodules. That's why did it such way.

@OpenCode
Copy link
Copy Markdown

OpenCode commented May 7, 2024

@leemannd IDK how to transfer git commit through different submodules. That's why did it such way.

You can follow this guide https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

@leemannd
Copy link
Copy Markdown
Contributor

leemannd commented May 8, 2024

@yankinmax It should work:

@yankinmax yankinmax force-pushed the add-passport_expiration branch from 93df64b to 3fd2098 Compare May 13, 2024 11:45
@yankinmax
Copy link
Copy Markdown
Author

@leemannd is ok now?

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 15, 2024
@leemannd
Copy link
Copy Markdown
Contributor

Hello @damdam-s , a review is welcome

@leemannd
Copy link
Copy Markdown
Contributor

Hello @OCA/human-resources-maintainers a review and merge is welcome

Copy link
Copy Markdown
Member

@damdam-s damdam-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@github-actions github-actions Bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
Comment thread passport_expiration/__manifest__.py Outdated
@yankinmax yankinmax force-pushed the add-passport_expiration branch from 3fd2098 to f10bd02 Compare September 23, 2024 09:36
@Saran440
Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1339-by-Saran440-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit c6d5737 into OCA:15.0 Sep 23, 2024
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 1fb03ad. Thanks a lot for contributing to OCA. ❤️

@giarve
Copy link
Copy Markdown

giarve commented May 3, 2025

For all people interested, there is the migration for 16.0 with a renamed module name #1468 with additional expiration date for ID document (not only passport)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants