Skip to content

[15.0][mig] passport_expiration#60

Open
damdam-s wants to merge 11 commits into
OCA:15.0from
damdam-s:15.0-mig-passport_expiration
Open

[15.0][mig] passport_expiration#60
damdam-s wants to merge 11 commits into
OCA:15.0from
damdam-s:15.0-mig-passport_expiration

Conversation

@damdam-s
Copy link
Copy Markdown
Member

@damdam-s damdam-s commented Jan 13, 2022

No description provided.

yankinmax
yankinmax approved these changes Jun 30, 2022
View reviewed changes
Comment thread passport_expiration/models/hr.py
OCA-git-bot and others added 2 commits June 30, 2022 11:07
@OCA-git-bot @damdam-s
[IMP] update dotfiles [ci skip]
c73282f
@damdam-s @yankinmax
Update passport_expiration/models/hr.py
45c7fe1 
Co-authored-by: Maksym Yankin <maksym.yankin@camptocamp.com>
@damdam-s damdam-s force-pushed the 15.0-mig-passport_expiration branch from 8d92fc2 to 45c7fe1 Compare June 30, 2022 09:07
leemannd
leemannd approved these changes Aug 4, 2022
View reviewed changes
Copy link
Copy Markdown

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration is technically legit.
I'm currently wondering if it shouldn't be moved to the repo OCA/hr.
This vertical-travel repository seems not much alive and adding a field on the employee is a module that I'll be looking into hr.

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Aug 4, 2022

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Copy Markdown

simahawk commented Feb 1, 2023

can you rebase?

Migration is technically legit. I'm currently wondering if it shouldn't be moved to the repo OCA/hr. This vertical-travel repository seems not much alive and adding a field on the employee is a module that I'll be looking into hr.

Seems more partner-contact-ish no?

@leemannd
Copy link
Copy Markdown

leemannd commented Feb 2, 2023

Added on the models and views of the hr.employee. So for me definitely hr related.
But the most important for me would be to have it into a repo that is more used and where it could be seen and used.

@yankinmax
Copy link
Copy Markdown

yankinmax commented Feb 2, 2023

@leemannd let me close this one and add this module to hr?

@yankinmax yankinmax mentioned this pull request Mar 29, 2024
Merged
1 task
@yankinmax
Copy link
Copy Markdown

yankinmax commented Mar 29, 2024

Superseded by:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 22, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@leemannd leemannd leemannd approved these changes

@yankinmax yankinmax yankinmax approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@damdam-s @OCA-git-bot @simahawk @leemannd @yankinmax @gurneyalex @oca-travis