[FIX] hr_employee_second_lastname: replace mapped address_home_id#1553
Open
xavierbol wants to merge 2 commits into
Open
[FIX] hr_employee_second_lastname: replace mapped address_home_id#1553xavierbol wants to merge 2 commits into
xavierbol wants to merge 2 commits into
Conversation
Contributor
|
Hi @luisg123v, |
MarwanBHL
approved these changes
Apr 24, 2026
BT-mgomez
approved these changes
May 13, 2026
|
@xavierbol @OCA-git-bot @MarwanBHL @BhaveshHeliconia Can this be merged? |
OCA-git-bot
added
mod:hr_employee_second_lastname
xavierbol
force-pushed
the
18.0-hr_employee_second_lastname-fix
branch
from
35a39f0 to
e8ed0a3
Compare
Author
|
Hello 👋🏼 I cannot test my fix correctly to improve the test coverage since my changes depend on the installation of I added a fixup commit containing some assets in unit test to check work_contact_id fields are correctly updated as expected. Let me know if it is useful or not, if yes, then I will squash it with the other commit. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace address_home_id mapped by work_contact_id. The relational field no longer exists on the address in V17 and replace by non relational field(Char) private_street.
Forward port fix (#1370) made in version 17
close #1551