Skip to content

[FIX] hr_employee_second_lastname: replace mapped address_home_id #1553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xavierbol wants to merge 2 commits into
base: 18.0
Choose a base branch
from
Open

[FIX] hr_employee_second_lastname: replace mapped address_home_id #1553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f00f98
[FIX] hr_employee_second_lastname: replace mapped address_home_id
DorianMAG Jun 19, 2024
e8ed0a3
fixup! [FIX] hr_employee_second_lastname: replace mapped address_home_id
xavierbol May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hr_employee_second_lastname/models/hr_employee.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def _prepare_vals_on_write_firstname_lastname(self, vals):
def _update_partner_firstname(self):
for employee in self:
partners = employee.mapped("user_id.partner_id")
partners |= employee.mapped("address_home_id")
partners |= employee.mapped("work_contact_id")
partners.write(
{
"firstname": employee.firstname,
Expand Down
14 changes: 14 additions & 0 deletions hr_employee_second_lastname/tests/test_hr_employee_second_lastname.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,27 @@ def test_auto_init_name(self):
self.assertEqual(employee_without_name, self.employee_model)

def test_change_name(self):
is_partner_lastname_installed = (
self.employee_model._is_partner_firstname_installed()
)
work_contact = self.employee1_id.work_contact_id
if is_partner_lastname_installed:
self.assertEqual(self.employee1_id.firstname, work_contact.firstname)
self.assertEqual(self.employee1_id.lastname, work_contact.lastname)
self.assertEqual(self.employee1_id.lastname2, work_contact.lastname2)
self.employee1_id.write({"name": "Pedro Martinez Torres"})
self.employee1_id.invalidate_recordset()

self.assertEqual(self.employee1_id.firstname, "Pedro")
self.assertEqual(self.employee1_id.lastname, "Martinez")
self.assertEqual(self.employee1_id.lastname2, "Torres")

if is_partner_lastname_installed:
work_contact.invalidate_recordset(["firstname", "lastname", "lastname2"])
self.assertEqual(work_contact.firstname, "Pedro")
self.assertEqual(work_contact.lastname, "Martinez")
self.assertEqual(work_contact.lastname2, "Torres")

def test_change_name_with_space(self):
self.employee1_id.write({"name": " Jean-Pierre Carnaud-Eyck"})
self.employee1_id.invalidate_recordset()
Expand Down
Loading