[19.0][MIG] l10n_us_partner_legal_number: Migration to 19.0#177
Draft
dnplkndll wants to merge 8 commits into
Draft
[19.0][MIG] l10n_us_partner_legal_number: Migration to 19.0#177dnplkndll wants to merge 8 commits into
dnplkndll wants to merge 8 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:l10n_us_partner_legal_number
dnplkndll
force-pushed
the
19.0-mig-l10n_us_partner_legal_number
branch
from
889010c to
045ce11
Compare
Closes the missing-tests/ HIGH finding from the OCA review. Adds 5 test methods covering the constraint that gates the module's value: - test_valid_ein_accepted (NN-NNNNNNN format) - test_valid_ssn_accepted (NNN-NN-NNNN format) - test_canadian_business_number_accepted (9 digits + check digit) - test_invalid_legal_id_raises (garbage string → UserError) - test_blank_legal_id_allowed (field is optional) All examples picked to pass python-stdnum's validators (e.g. CBN 123456782 has a valid Luhn check digit, SSN avoids the 666/9XX/00 blacklisted ranges). Pattern mirrors l10n_us_account_routing/tests/test_routing_number_bank.py.
dnplkndll
force-pushed
the
19.0-mig-l10n_us_partner_legal_number
branch
from
045ce11 to
f7f1fd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of l10n_us_partner_legal_number to Odoo 19.0.